Because the key two rows below `NumLock` is `Key_Quote` on the base layer too,
and is not a numpad-specific key either, make it transparent, so it does not get
highlighted erroneously.
Thanks to @ImmaculatePotato and Eddie Jinks for reporting the issue, and
proposing the fix.
Fixes#48.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
I added a couple items to the list of things that should be documented.
I also realize I have no idea what the ANY key does, but I'm intrigued. I don't understand from these code comments, and don't have time to puzzle it out now.
Otherwise, though, this is so much better than the file I've been poking at for weeks! It's clear and clean and much more welcoming. Thanks for all the behind the scenes work that made this possible, and thank you Jesse for the work writing up comments!
This lass is not fond of backslash, so she made the sketch use backslash
less, so much so that it is now backslash-less.
Signed-off-by: Csilla Nagyné Martinák <csilla@csillger.hu>
For a while now, `Kaleidoscope.use` does not require a NULL sentinel at
the end. This drops the sentinel instead of adding documentation that
would explain why that NULL is there.
Signed-off-by: Csilla Nagyné Martinák <csilla@csillger.hu>
I feel weird about putting the name before the word 'keymap', but this
seems less confusing than explaining why KEYMAP_QWERTY and
KEYMAP_STACKED are different kidns of entitites
The NumLock plugin works without a macro now, so we can simplify the factory
firmware by just using `Key_KeypadNumLock`.
Signed-off-by: Gergely Nagy <kaleidoscope@gergo.csillger.hu>
When both `Fn` keys are `KeymapNext_Momentary`, holding both would get us to the
`NUMPAD` layer, which overrides the palm keys and turns them into
`Keymap1_Momentary` keys. Thus, when releasing them, we would receive a release
event for `Keymap1_Momentary`, not for `KeymapNext_Momentary`, and we'd be stuck
on the `Numpad` layer until toggling it off.
To avoid this scenario, change the `KeymapNext_Momentary` keys into
`Keymap1_Momentary`, so we never reach the `NUMPAD` layer via the `Fn` keys.
Fixeskeyboardio/Kaleidoscope#151, with thanks to @chughes87 for the report!
Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
