This change adds a build recipe that pastes a header and footer file
to the preprocessed sketch file.
Signed-off-by: Florian Fleissner <florian.fleissner@inpartik.de>
In rare occasions during development when e.g. a missing symbol caused
the linker process to abort, the joined library was not removed
at the end of the build. In subsequent builds this possibly
caused problems during creation of the joined library as a
static library cannot be updated but must be removed and re-created.
This change solves the described problem by removing a possibly
pre-exising joined library before the link.
Signed-off-by: Florian Fleissner <florian.fleissner@inpartik.de>
Before this change, when Arduino was linking the elf binary, it added all
objects and archives (libraries/plugins) to a long linker command line.
This would sometimes cause issues due to the linker's gargabe collection feature.
When one library A referenced a symbol from a library B but library A appeared after B
in the linker command line, the referenced symbol was in some cases garbage
collected as to the linker it appeared to be unreferenced.
To understand this better it is important to know that the linker processes
objects and archives one by one in the order of their appearance at the command
line. For every object or archive encountered it runs garbage collection individually.
That's why symbols might get discarded although an object or archives that is
encountered later on while processing the linker command line might have referenced it.
To fix this problem this commit divides up the linker process into two steps.
First, all objects and archives are combined in a large .a archive. Then, this
archive is passed to the original linker command line, thereby replacing the
original set of objects and archives.
The final link now sees all symbols together. Thus, it is able to determine the true
interdependencies and do a proper garbage collection without accidentally
generating unresolved symbols.
With this fix, the order of appearance of include directives in the sketch file that formerly had an
influence on the link order (as Arduino passes library archives to the linker in
the order of the appearance of the matching includes in the sketch),
can now be savely chosen arbitrarily.
To erase the joined archive file that is generated from all objects and
archives, we have to use different solutions on Linux/macOS and Windows. This is
done via defining tools.rm.cmd differently for those platforms.
Signed-off-by: Florian Fleissner <florian.fleissner@inpartik.de>
As a side effect, this changes the dfu-programmer invocation in platform.txt for
all boards (Planck included) that use it.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
